Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - [DnD5e] - Container dropped on a token is not dropped with the contained items #688

Open
5 tasks done
ToumouGaming opened this issue Dec 13, 2024 · 4 comments
Open
5 tasks done
Labels
bug Something isn't working

Comments

@ToumouGaming
Copy link

ToumouGaming commented Dec 13, 2024

I confirm the following:

  • I am on the latest version of Item Piles
  • I have tried to clear my cache (Ctrl / Cmd + F5)
  • I have checked the console for errors (F12 to open, Console tab)
  • I have tried to reset Item Piles' system settings
  • I have reproduced this bug with only item piles & its dependency modules enabled

Describe the bug
As GM, when I try to drag and drop a container (like a bag) with items in from a character sheet on another player token, all the container and items in are transfered. If I do the same thing with player side or with the player connected, only the container is transfered, not the items contained. I suppose that is due to confirmation request.

To Reproduce

  1. Connect as GM and connect one player.
  2. Add a container (like a bag) to a character sheet of a non connected player.
  3. Add an item in this container.
  4. Drag and drop the container from the character sheet to the token of the connected player.
  5. Accept the request with connected player.
  6. See that the container correctly move but not the contained item. Item is placed on original character sheet inventory.

Expected behavior
Containers and contained items transfered as a drag and drop is suppose to be.

Screenshots
Every time I have to validate this dialog, the bug appears. (sry for the french language)
Capture d'écran 2024-12-13 062745

Setup

  • Foundry Version: 12.331
  • System Version: DND5e 4.1.2
  • Item Piles Version: 3.1.6
  • Browser & version: tested with Google Chrome 131.0.6778.109

Active modules

  • Item Piles
  • libwrapper
  • socketlib

Additional context
As I said before, it perfectly works if you tried with only GM connected. I assume that is due to the confirmation request step.

@ToumouGaming ToumouGaming added the bug Something isn't working label Dec 13, 2024
@Haxxer
Copy link
Collaborator

Haxxer commented Dec 13, 2024

See #662

@ToumouGaming
Copy link
Author

Oh ok. No update planned for these version of DnD?
Thanks for this answer anyway ! And for the module =)

@ToumouGaming
Copy link
Author

I did the same manipulations on DnD 3.3.1, with only Item Piles active (and dependances) on a new clean world.
Bug is real.

@ToumouGaming
Copy link
Author

ToumouGaming commented Dec 14, 2024

I worked around the problem in the _giveItem() function of the module.js file by adding "const bypass = true" and adding it to all isGM conditions present in the function. So I prevent the dialog window and the containers are correctly exchanged.

This allows me to maintain my next session while waiting for a real correction to be made.

Good luck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants