Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - [DND5E] - Item Piles dropCanvasData event hook causing issue with MidiQOLs dropCanvasData event hook #674

Open
5 tasks done
gambit07 opened this issue Oct 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@gambit07
Copy link

I confirm the following:

  • I am on the latest version of Item Piles
  • I have tried to clear my cache (Ctrl / Cmd + F5)
  • I have checked the console for errors (F12 to open, Console tab)
  • I have tried to reset Item Piles' system settings
  • I have reproduced this bug with only item piles & its dependency modules enabled

Describe the bug
With MidiQOL enabled, the dropCanvasData hook is being called by both Midi and Item Piles on init. This causes an issue with MidiQOLs drag and drop targeting, where an attack item does not get its proficiency bonus added to the attack

To Reproduce
Steps to reproduce the behavior:

  • Reload world
  • Add a fire elemental and Starter Hero to canvas with both MidiQOL and Item Piles enabled. Enable Drag and Drop Targeting in MidiQOL.
  • Attack using the fire elementals Touch attack by dragging the item from the sheet to the Starter Hero. The attack dialog will display 1d20 + 3 + @bonus
  • Reload World
  • Attack using the fire elementals Touch attack by using foundrys normal targeting system. The attack dialog will display 1d20 + 3 + 3 + @bonus

Expected behavior
This behavior seems to occur after a world reload, the first time a npc token attacks and damages a target. Once damage is done, the proficiency bonus seems to be added as normal with drag and drop. Expected behavior is that the first attack would include the proficiency bonus as well.

Screenshots

itemPilesNoProfBonus.mp4

Setup

  • Foundry Version: [12.331]
  • System Version: [DND5e 3.3.1]
  • Item Piles Version: [3.1.6]
  • MidiQOL Version: [11.6.25.1]
  • Browser & version [Rippers Client 1.5.5]

Active modules

  • Item Piles
  • libwrapper
  • socketlib
  • MidiQOL + Dependencies

Additional context
Add any other context about the problem here.

@gambit07 gambit07 added the bug Something isn't working label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant