Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacking window 'message' event listeners #682

Open
ExileofAranei opened this issue Aug 23, 2024 · 1 comment
Open

Stacking window 'message' event listeners #682

ExileofAranei opened this issue Aug 23, 2024 · 1 comment
Labels
needs triage This issue has not been triaged by maintainers

Comments

@ExileofAranei
Copy link

Describe the bug

Hi, just noticed that Html plugin does not remove it's listener for message event, plugin's detach function is not called on fancybox destroy so window.removeEventListener is also never called. It tends to adding listeners for such event on each fancybox opening. Sure it won't cause serious performance issues, but it worths mentioning anyway

Tested on my websites with latest version, screenshot is captured on yours
image

Reproduction

Open fancybox multiple times and check listeners for message event

Additional context

No response

@ExileofAranei ExileofAranei added the needs triage This issue has not been triaged by maintainers label Aug 23, 2024
@fancyapps
Copy link
Owner

Hi, Thanks for the reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has not been triaged by maintainers
Projects
None yet
Development

No branches or pull requests

2 participants