Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to combined modules (index.js) #681

Open
devjam1n opened this issue Aug 22, 2024 · 0 comments
Open

Enhancements to combined modules (index.js) #681

devjam1n opened this issue Aug 22, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@devjam1n
Copy link

devjam1n commented Aug 22, 2024

Is your feature request related to a problem? Please describe.

Yes, there's an issue with the current distribution of index.esm.js and index.umd.js. Even though Thumbs module is included in the code (as it is required by Fancybox), it is not exported. This oversight requires importing thumbs module again leading to redundant code.

Describe the solution you'd like

Include the Thumbs module in the exports at the bottom of both the index.esm.js and index.umd.js files, alongside Carousel, Fancybox, and Panzoom.

Update the official documentation and CDN instructions to reflect that all these modules can be used in a bundled way if you need all of them and performance is critical.

Describe alternatives you've considered

No response

Additional context

No response

@fancyapps fancyapps added the enhancement New feature or request label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants