Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fancybox.getInstance is incorrectly typed, missing string option #654

Open
Razunter opened this issue May 6, 2024 · 2 comments
Open

Fancybox.getInstance is incorrectly typed, missing string option #654

Razunter opened this issue May 6, 2024 · 2 comments
Labels
needs triage This issue has not been triaged by maintainers

Comments

@Razunter
Copy link

Razunter commented May 6, 2024

Describe the bug

Fancybox.d.ts contains static getInstance(id?: number): Fancybox | null;

while Options.d.ts types id as string | number

Reproduction

Types issue

Additional context

No response

@Razunter Razunter added the needs triage This issue has not been triaged by maintainers label May 6, 2024
@Razunter
Copy link
Author

Razunter commented May 7, 2024

In addition, maybe Images.content option should allow for undefined return value. Currently, it's content?: (instance: Images, slide: slideType) => string | HTMLElement | HTMLPictureElement;, making it content?: (instance: Images, slide: slideType) => string | HTMLElement | HTMLPictureElement | undefined; would make sense.

@Razunter
Copy link
Author

slideType doesn't have iframeAttr, but it works and in docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage This issue has not been triaged by maintainers
Projects
None yet
Development

No branches or pull requests

1 participant