Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New nb_NO strings #286

Merged
merged 1 commit into from
May 13, 2023
Merged

New nb_NO strings #286

merged 1 commit into from
May 13, 2023

Conversation

comradekingu
Copy link
Contributor

@comradekingu comradekingu commented Apr 22, 2023

For #80

Description

<item>12-timersklokke + AM/PM</item>
<item>24-timers</item>
<item>12-timers</item>
<item>12-timers + AM/PM</item>
<item>Analog</item>
<item>Dato og klokkeslett</item>
<item>Full dato og klokkeslett</item>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2 lines below this one should also be translated:

<item>Date without time</item>
<item>Full date without time</item>

@falzonv
Copy link
Owner

falzonv commented May 13, 2023

Aside from the 2 missing strings (below), everything looks good so I will merge this PR, thank you for the update!

When you get some time, could you please write the missing strings here as a comment?

      <!-- Clock format -->
      <string name="set_clock_format">Format</string>
      <string-array name="set_clock_format_entries">
          <item>None (hide)</item>
          <item>24 hours</item>
          <item>12 hours</item>
          <item>12 hours + AM/PM</item>
          <item>Analog</item>
          <item>Date and time</item>
          <item>Full date and time</item>
NEW       <item>Date without time</item>
NEW       <item>Full date without time</item>
      </string-array>

@falzonv falzonv merged commit 9086162 into falzonv:main May 13, 2023
@comradekingu
Copy link
Contributor Author

@falzonv

<item>Dato uten klokkeslett</item>
<item>Full dato uten klokkeslett</item>

@falzonv
Copy link
Owner

falzonv commented May 13, 2023

Thank you, integrated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants