Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC Authentication for Alertmanager and Loki #712

Closed
dmolik opened this issue Dec 5, 2023 · 9 comments · May be fixed by #793
Closed

OIDC Authentication for Alertmanager and Loki #712

dmolik opened this issue Dec 5, 2023 · 9 comments · May be fixed by #793
Assignees
Labels
kind/feature New feature or request lifecycle/rotten
Milestone

Comments

@dmolik
Copy link

dmolik commented Dec 5, 2023

Motivation

I'm trying to push outputs to Alertmanager and Loki, but cross-cluster traffic is authenticated via Service Accounts in OIDC.

Feature

Support OIDC clients in both Loki and Alertmanager outputs.

I'm happy to commit up a PR, but this is potentially a 'more involved' code change so I would like to discuss, scope and approach, and acceptance criteria.

@dmolik dmolik added the kind/feature New feature or request label Dec 5, 2023
@Issif Issif added this to the 2.29.0 milestone Dec 8, 2023
@Issif
Copy link
Member

Issif commented Dec 8, 2023

You're right, it might imply a lot of changes, let me dig first

@dmolik
Copy link
Author

dmolik commented Dec 16, 2023

Had a discussion out of band, long and short of it, going to try to extend the existing http client with OIDC auth instead of using the Loki or Alertmanager clients

@Issif
Copy link
Member

Issif commented Dec 17, 2023

You mean the http client shared between the different outputs? If you do so, it means more than Loki and AlertManager will have the benefit, so their configs must be adapted either.

@poiana
Copy link

poiana commented Mar 16, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@dmolik
Copy link
Author

dmolik commented Mar 17, 2024

/remove-lifecycle stale

@Issif Issif moved this from To do to In progress in Falcosidekick 2.x Apr 26, 2024
@Issif Issif self-assigned this Apr 30, 2024
@Issif Issif modified the milestones: 2.29.0, 2.30 Jun 24, 2024
@poiana
Copy link

poiana commented Sep 22, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@poiana
Copy link

poiana commented Oct 22, 2024

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

@poiana
Copy link

poiana commented Nov 21, 2024

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana poiana closed this as completed Nov 21, 2024
@poiana
Copy link

poiana commented Nov 21, 2024

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation bot moved this from In progress to Done in Falcosidekick 2.x Nov 21, 2024
@Issif Issif modified the milestones: 2.30, 2.x Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request lifecycle/rotten
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants