Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make linux_hostinfo platform optional #3411

Closed
jemag opened this issue Oct 18, 2024 · 4 comments · Fixed by #3412
Closed

Make linux_hostinfo platform optional #3411

jemag opened this issue Oct 18, 2024 · 4 comments · Fixed by #3412
Milestone

Comments

@jemag
Copy link

jemag commented Oct 18, 2024

Motivation

After discussion in the following issue: falcosecurity/charts#754 , what I could gather is that the new linux_hostinfo platform provides additional information to plugins should they need it.

However, Falco being a fairly general tool to process event streams and apply rules to them, plugins can be made to target event streams where the hostinfo of where Falco is running is irrelevant, or of very little concern.

I think it would be great if this could be optional, so that, when deployed to Kubernetes, hostPath is not required.

Feature
Make the new linux_hostinfo platform optional so that it can be turned off and hostPath isn't required.

Alternatives
Keep hostPath even though it is not required by plugin.

@FedeDP
Copy link
Contributor

FedeDP commented Nov 21, 2024

Hi! Thanks for opening this issue!
I'd move this to Falco since libs is already agnostic, the platform gets requested by Falco when opening plugins: https://github.com/falcosecurity/falco/blob/master/userspace/falco/app/actions/helpers_inspector.cpp#L64

Indeed, we could add a Falco config key to disable the default behavior of adding hostinfo to the plugin run, wdyt?

@FedeDP FedeDP transferred this issue from falcosecurity/libs Nov 21, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Nov 21, 2024

/milestone 0.40.0

@poiana poiana added this to the 0.40.0 milestone Nov 21, 2024
@jemag
Copy link
Author

jemag commented Nov 21, 2024

Indeed, we could add a Falco config key to disable the default behavior of adding hostinfo to the plugin run, wdyt?

That would be great!

@FedeDP
Copy link
Contributor

FedeDP commented Nov 22, 2024

Opened #3412 to implement the new config key!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants