Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to define an image pull secret for Falco Talon #820

Open
ddrpgmv opened this issue Jan 24, 2025 · 3 comments · May be fixed by #821
Open

Unable to define an image pull secret for Falco Talon #820

ddrpgmv opened this issue Jan 24, 2025 · 3 comments · May be fixed by #821
Assignees
@Issif
Labels
kind/bug Something isn't working

Comments

@ddrpgmv
Copy link

ddrpgmv commented Jan 24, 2025

Describe the bug
Although an imagePullSecrets field is defined in the values.yaml, this field is not included in the templates/deployment.yaml file

Expected behaviour

Falco Talon deployment spec should include an imagePullSecrets entry if a value has been set in the values.yaml file

Environment

Falco Talon chart version 0.2.2
@ddrpgmv ddrpgmv added the kind/bug Something isn't working label Jan 24, 2025
@Issif
Copy link
Member

Issif commented Jan 24, 2025

Good catch. I'm expecting to release the 0.3 in the next weeks, I'll fix that at the same time. If it's urgent, you can propose a PR for sure. Thanks.

@Issif Issif self-assigned this Jan 24, 2025
@ddrpgmv
Copy link
Author

ddrpgmv commented Jan 24, 2025

It is not urgent. But of course, if it is ok for you I can propose a PR.

@Issif
Copy link
Member

Issif commented Jan 24, 2025

It is not urgent. But of course, if it is ok for you I can propose a PR.

All PR are welcome, all the Falco ecosystem is community driven 😄

@ddrpgmv ddrpgmv linked a pull request Jan 24, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Issif Issif

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix-falcon-talon-chart-pull-secret ddrpgmv/charts
2 participants
@Issif @ddrpgmv