ImagePullSecrets not consistent across Charts

[rriverak]

Describe the bug

If we install the latest Version of falcosecurity/falco Chart with a custom ImagePullSecrets we got a different rendering behavior from the Sidekick Subcharts.

How to reproduce it

Install the falcosecurity/falco Chart with custom ImagePullSecrets for Falco and Falcosidekick.

imagePullSecrets: 
  - name: my-secret

falcosidekick:
  enabled: true
  imagePullSecrets:
    - name: my-secret

the Manifest for the falco Chart itself everything looks good.

imagePullSecrets:
  - name: my-secret

but on the Sidekick Subchart we got a broken entry:

imagePullSecrets:
  - name: map[name:my-secret]

Quickfix
In order to generate a valid manifest, the key "name" must be removed from the imagePullSecrets list in Falcosidekick.

imagePullSecrets: 
  - name: my-secret

falcosidekick:
  enabled: true
  imagePullSecrets:
    - my-secret

Expected behaviour

Same interpolation logic across all charts or add at least a Note to the Docs.

[Issif]

You're right. Thanks for the notice.

Basically, we have 2 behaviors here:

• Falco/Event-generator/Falco-exporter expect a list of objects with this format:

   - name: secret

• Falcosidekick/UI expect a list of strings:

   - secret

Right now, the imagePullSecrets field for the deployments/pods can only have a name but it would make sense in the future to have more options, so it seems better to consider a list of objects and not a list of strings. I'll change the behavior in Falcosidekick chart to have consistency.

[poiana]

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

[leogr]

Hey @Issif , has this been addressed yet? 🤔
/remove-lifecycle stale

[Issif]

Hey @Issif , has this been addressed yet? 🤔 /remove-lifecycle stale

nope, I'm adding it in my todo but it implies some breaking changes

[poiana]

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

[poiana]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

[leogr]

Hey @Issif , has this been addressed yet? 🤔 /remove-lifecycle stale

nope, I'm adding it in my todo but it implies some breaking changes

Any updates?
/remove-lifecycle rotten

[Issif]

Hey @Issif , has this been addressed yet? 🤔 /remove-lifecycle stale

nope, I'm adding it in my todo but it implies some breaking changes

Any updates?
/remove-lifecycle rotten

No change til now, it will create a breaking change for the users. Let me add this in the PR I'm preparing for another fix