chore: drop python 3.7 and use ruff/poetry-check/pyupgrade #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
force-pushed
the
ruslan/ci-lint-maintain
branch
2 times, most recently
from
dfecaca
to
0caab49
Compare
squat
reviewed
Apr 1, 2024
efiop
commented
Apr 1, 2024
.github/workflows/test.yml
Outdated
| run: | | ||
| python -m pip install uv | ||
|
|
||
| - name: Test | ||
| run: | | ||
| export ISOLATE_PYENV_EXECUTABLE=pyenv/bin/pyenv | ||
| python -m pytest -vvv | ||
| python -m pytest -vvv -n auto |
There was a problem hiding this comment.
Looks like some of our stuff is running into each other, will do that in a separate PR.
efiop
force-pushed
the
ruslan/ci-lint-maintain
branch
from
0caab49
to
1b443d4
Compare
efiop
changed the title
|
Let me see if I can bring back (i mean back into this PR) xdist, it cut time by half but was causing some issues in our tests. Will do it in a separate PR. |
efiop
force-pushed
the
ruslan/ci-lint-maintain
branch
3 times, most recently
from
8f23a2d
to
cbe48c8
Compare
efiop
commented
Apr 1, 2024
efiop
force-pushed
the
ruslan/ci-lint-maintain
branch
from
cbe48c8
to
b252ab4
Compare
efiop
added a commit
that referenced
this pull request
May 23, 2024
* lint: use ruff * chore: add poetry-check to pre-commit * chore: drop python 3.7 * chore: add pre-commit to gha * chore: run tests on schedule * chore: only test 3.8 and 3.11 on macos * fix(test): readlinks for python before comparing
efiop
added a commit
that referenced
this pull request
May 24, 2024
….7 (#136) * chore: revert to v0.12.7 * build: add cloudpickle to agent requirements (#118) * chore: drop python 3.7 and use ruff/poetry-check/pyupgrade (#119) * lint: use ruff * chore: add poetry-check to pre-commit * chore: drop python 3.7 * chore: add pre-commit to gha * chore: run tests on schedule * chore: only test 3.8 and 3.11 on macos * fix(test): readlinks for python before comparing * fix(conda): use --yes instead of --force (#123) A few days ago conda 24.3.0 removed `--force` completely causing this to no longer work. `--yes` has been around for more than a year now and we don't really need to support old conda/miniconda so we can just directly replace it and not bother with compatibility with older versions. https://github.com/conda/conda/releases/tag/24.3.0 * chore: revisit build/test/release process (#126) * chore: use setuptools instead of poetry * chore: introduce dev extra * chore(gha): revisit release process * chore: activate more ruff rules * chore: delete cliff.toml (#127) No longer used. * feat(backend): Add container backend (#135) --------- Co-authored-by: Kemal Akkoyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to deal with isolate a bit more and our lint and ci are pretty slow, so done a little bit of cleanup to speed it up by using ruff and a few more linters. No functional changes.