Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Commit

Permalink
feat: use dbt-athena-community for athena profile
Browse files Browse the repository at this point in the history
  • Loading branch information
chamini2 committed Mar 7, 2023
1 parent 5ae3e2a commit 6ef06d5
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/actions/setup-local-fal/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ runs:
# overwrite for specific adapters
if [[ '${{ inputs.adapter }}' == 'athena' ]]
then
package=dbt-athena-adapter
package=dbt-athena-community
fi
if [[ '${{ inputs.dbt }}' == 'latest' ]]
Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/test_integration_cli.yml
Original file line number Diff line number Diff line change
Expand Up @@ -214,15 +214,13 @@ jobs:
dbt: "1.1.*"
- profile: "fal"
dbt: "1.2.*"
# dbt-athena-adapter only supports dbt-core==1.0.* for now
# dbt-athena-adapter only supports dbt-core>=1.3
- profile: "athena"
dbt: "1.0.*"
- profile: "athena"
dbt: "1.1.*"
- profile: "athena"
dbt: "1.2.*"
- profile: "athena"
dbt: "1.3.*"
- profile: "athena"
dbt: "1.4.*"

# Run only the latest commit pushed to PR
concurrency:
Expand Down
4 changes: 2 additions & 2 deletions projects/fal/src/fal/packages/dependency_analysis.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ def _get_dbt_packages() -> Iterator[Tuple[str, Optional[str]]]:
# the PyPI names instead of the import names). An example distribution info is the following, which
# contains both the main exporter of the top-level name (dbt-core) as well as all the packages that
# export anything to that namespace:
# {"dbt": ["dbt-core", "dbt-postgres", "dbt-athena-adapter"]}
# {"dbt": ["dbt-core", "dbt-postgres", "dbt-athena-community"]}
#
# This won't only include dbt.adapters.xxx, but anything that might export anything to the dbt namespace
# (e.g. a hypothetical plugin that only exports stuff to dbt.includes.xxx) which in theory would allow us
Expand Down Expand Up @@ -72,7 +72,7 @@ def _find_fal_extras(package: str) -> set[str]:

# This list is different from the one we obtain in _get_dbt_packages
# since the names here are the actual import names, not the PyPI names
# (e.g. this one will say athena, and the other one will say dbt-athena-adapter).
# (e.g. this one will say athena, and the other one will say dbt-athena-community).
available_dbt_adapters = {
module_info.name
for module_info in pkgutil.iter_modules(dbt.adapters.__path__)
Expand Down

0 comments on commit 6ef06d5

Please sign in to comment.