Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "options" property from RedisClient #58

Open
ksmithut opened this issue Jul 12, 2018 · 0 comments
Open

Missing "options" property from RedisClient #58

ksmithut opened this issue Jul 12, 2018 · 0 comments

Comments

@ksmithut
Copy link

The redis-mock library is missing the "options" property from the RedisClient. I'm using a library called cache-manager-redis-store that uses redis to manage a cache. On this line, they access the options property and subsequently options that were normalized upon instantiation, which I assume is a normalized options object based on what was passed into the createClient method taking into account that people might call createClient with varying function signatures, e.g. .createClient(redisUrl, redisOptions), or .createClient(redisOptions). Here are the relevant lines (1) (2) in the node_redis project where node_redis is normalizing these options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant