From 96c2c05d98bcd52407fbff58b89beb4260eefe28 Mon Sep 17 00:00:00 2001 From: Georges Berenger Date: Tue, 14 Jan 2025 09:38:47 -0800 Subject: [PATCH] Fix VRSFileReadTest crasher Summary: Cache blocks in the async queue are referenced by pointer, so copying them when purging isn't safe. This explains long standing crashes with VRSFileReadTest. Differential Revision: D68143287 fbshipit-source-id: b37abc66c6ce384c6e7ca1d34981082ab7288c94 --- vrs/FileCache.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vrs/FileCache.h b/vrs/FileCache.h index fb6fe4d6..da639468 100644 --- a/vrs/FileCache.h +++ b/vrs/FileCache.h @@ -48,7 +48,7 @@ class FileCache { /// Look-up a file in the cache. /// @param filename: a filename for the object. /// @param outFilePath: a path to the object in the cache. - /// @return 0 if the file exists, and outFilePath has bee set. + /// @return 0 if the file exists, and outFilePath has been set. /// Returns FILE_NOT_FOUND if the file doesn't exist, and outFilePath has been set, for you to /// add the object in the cache at that location. /// Returns another error code and outFilePath isn't set, if some error occurred, and the object