Allow for multiple services per endoint #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/com/meta/cp4m/message/FBMessageHandler.java # src/test/java/com/meta/cp4m/message/FBMessageHandlerTest.java
|
@hunterjackson Hey the changes look good to me. Hard to do a deep dive on each file because it is such a large diff. Can we have a meeting to discuss the changes here? Next week or in the new year :) |
NanditaRao
approved these changes
Dec 21, 2023
# Conflicts: # src/main/java/com/meta/cp4m/message/FBMessageHandler.java # src/main/java/com/meta/cp4m/message/FBMessengerConfig.java # src/test/java/com/meta/cp4m/message/FBMessageHandlerTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically before things would fail if you defined the same path in multiple handlers, now you can register multiple handlers to the same path and we'll route it to the correct handler