Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Jest for nuclide-test-runner #214

Open
DaleLJefferson opened this issue Oct 7, 2015 · 11 comments
Open

Jest for nuclide-test-runner #214

DaleLJefferson opened this issue Oct 7, 2015 · 11 comments

Comments

@DaleLJefferson
Copy link

Since Jest is another Facebook project, can I expect that we will see a Jest nuclide-test-runner?

@ssorallen
Copy link
Contributor

A test runner for Jest is something I'd like to add. The test runner interface currently expects JSON output (current JSON shape is in TestSuiteModel.js:19), which Jest/Jasmine do not bundle yet. jestjs/jest#513 is open to integrate with Arcanist, the CLI for Phabricator which also consumes JSON output for unit testing.

It's possible for a test runner to simply write unstructured output to the buffer, but it would offer little more than typing jest on the command line. Would you find it useful for the first iteration to effectively be a button that runs jest and writes stdout output into Nuclide?

@DaleLJefferson
Copy link
Author

Thanks for replying, yes being able to run npm test via a button in Nuclide would be a useful first step.

@tychota
Copy link

tychota commented Jun 25, 2016

Based on jestjs/jest@5413b7b,
json output seems to be supported for a while.

I'm not against contributing but I've no idea what to do.
In peculiar is something like https://github.com/klorenz/nuclide-test-runner-pytest/blob/master/lib/nuclide-test-runner-pytest.coffee a great example of modern nuclide test runner provider or have you an better example (nuclide-jasmine ?)

@JosePedroDias
Copy link

I'm attempting to create one here:
https://github.com/JosePedroDias/nuclide-test-runner-jest
https://atom.io/packages/nuclide-test-runner-jest

@bsr203
Copy link

bsr203 commented Jan 16, 2017

While discussing with @cpojer, he mentioned @kentaromiura is the right person to approach with this request.

Along with the test runner, it would also be great to have code coverage support as jest supports it natively. There are some packages available, but has some usability issues. It would be great to have something similar to flow coverage, where it highlights when click the percentage status on bottom. Also great to have a tree view of coverage, may be in a panel.

thanks for your work on this.

https://github.com/taskworld/atom-lcov
https://github.com/jacogr/atom-lcov-info
https://github.com/philipgiuliani/coverage

@mfrachet
Copy link

mfrachet commented Aug 4, 2017

Any new informations concerning this issue ?

@Peeja
Copy link

Peeja commented Sep 19, 2017

nuclide currently depends on jest-editor-support. Does that mean there's some sort of Jest support in Nuclide today? I can't find anything documented.

@cpojer
Copy link

cpojer commented Sep 19, 2017

Not currently.

@paulbrittain
Copy link

Since this isn't something Nuclide is supporting or planning to support, what are most people using to debug jest tests on Atom?

@aaronabramov
Copy link
Contributor

@captbaritone does oss nuclide come with a debugger? in this case running jest with node --inspect-brk ./node_modules/.bin/jest --runInBand myTestFile.js and attaching debugger from nuclide should do the trick

@ermik
Copy link

ermik commented Aug 21, 2018

This issue was a 2017 goal for Jest. Let's make up a featureset that would be representative of the sophisticated nature of both Nuclide and Jest and see if the community, myself included, can tackle this. VSCode has a Jest runner, I can't live with that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests