Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

nuclide-js-imports-server/nuclide-js-imports-client doesn't work #1643

Open
PinkaminaDianePie opened this issue Oct 23, 2018 · 1 comment
Open

Comments

@PinkaminaDianePie
Copy link
Contributor

PinkaminaDianePie commented Oct 23, 2018

Issue and Steps to Reproduce

Nuclide doesn't start server and client for js imports. When I click on the unimported token in JS files it should show the list of possible imports to add, same should be shown when I typing imports by myself at the top of the file. However, server and client for imports doesn't even loads by Atom. I've tried to modify file .atom/packages/nuclide/pkg/nuclide-js-imports-client/lib and put console.log at the top of file, and it doesn't appear in Atom dev tools on start. Same for the server. I also tried to remove activationHooks from package.json and in that case client starts to load and show my console.log, but after that fails because it can't connect to imports server. In Nuclide settings, I have only default values for the nuclide-js-imports-client
image
I also tried to make it always enabled but with no success:
image

I've tried different versions of the Nuclide, last working version is 0.345.0 after it imports doesn't work.

Expected Behavior

List with possible tokens to import should be displayed.

Actual Behavior

Nothing happens, autocomplete for file imports doesn't appear.

Versions

  • Atom: 1.31.1
  • Nuclide: 0.345.0 - 0.357.0
  • Client OS: Ubuntu 18.04

Additional Details

@AfflatusX
Copy link

thank you @PinkaminaDianePie for posting the last working version! I was so frustrated when noticing auto import stopped working after upgrading Nuclide - luckily at least I can roll back.

Nuclide team, can we make sure core features like this does not break during new releases? This is a significant regression that impacts developer's efficiency.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants