[nuclide-server] no longer starts after v0.0.28 update

[arsenx]

I had been using the nuclide-server feature since the version prior v0.0.25 and had a problem running it over https so used the [-k] parameter with the nuclide-server-start and it worked like a charm.

After the update to v0.0.28 I receive the same error using https error even though I am using the [-k] parameter. Only difference is that now I have no logs in ~/nuclide.nohup.out.

Might be worth looking into the changes implemented over the 0.0.26 to 0.0.28

[bolinfest]

We started pre-transpiling the .js in v0.0.28 with the expectation that the server should start up faster now that it no longer has to transpile on the fly.

[bolinfest]

Hmm, it appears that nuclide-buck-base/lib/BuckUtils.js was transpiled whereas it should not have been.

[bolinfest]

All of the other services that were not supposed to be transpiled according to services-config.json were left alone as intended, though.

A quick fix is to edit nuclide-server/services-config.json and remove the following:

  {
    "definition": "nuclide-buck-base/lib/BuckUtils.js",
    "implementation": "nuclide-buck-base/lib/LocalBuckUtils.js",
    "name": "BuckUtils",
    "useServiceFramework": true
  },

[bolinfest]

Ah, I see what happened. There are two entries for nuclide-buck-base:

  {
    "definition": "nuclide-buck-base/lib/BuckUtils.js",
    "implementation": "nuclide-buck-base/lib/LocalBuckUtils.js",
    "name": "BuckUtils",
    "useServiceFramework": true
  },
  {
    "definition": "nuclide-buck-base/lib/BuckProject.js",
    "implementation": "nuclide-buck-base/lib/LocalBuckProject.js",
    "name": "BuckProject",
    "useServiceFramework": true
  },

One clobbered the other.

[bolinfest]

e26aafa is the fix for this. Doing a release now.

[arsenx]

Just updated the server to v0.0.29 should I expect a release for atom as well? Because now I am getting an assertion error

assert.js:87
Hide Stack Trace
AssertionError: undefined == true
  at SshHandshake._updateServerInfo (/Users/arsenx/.atom/packages/nuclide-remote-projects/node_modules/nuclide-remote-connection/lib/SshHandshake.js:169:7)
  at Channel.<anonymous> (/Users/arsenx/.atom/packages/nuclide-remote-projects/node_modules/nuclide-remote-connection/lib/SshHandshake.js:237:22)
  at emitOne (events.js:77:13)
  at Channel.emit (events.js:166:7)
  at SSH2Stream.<anonymous> (/Users/arsenx/.atom/packages/nuclide-remote-projects/node_modules/nuclide-remote-connection/node_modules/ssh2/lib/Channel.js:125:14)
  at SSH2Stream.g (events.js:257:16)
  at emitNone (events.js:67:13)
  at SSH2Stream.emit (events.js:163:7)
  at parsePacket (/Users/arsenx/.atom/packages/nuclide-remote-projects/node_modules/nuclide-remote-connection/node_modules/ssh2/node_modules/ssh2-streams/lib/ssh.js:3437:10)
  at SSH2Stream._transform (/Users/arsenx/.atom/packages/nuclide-remote-projects/node_modules/nuclide-remote-connection/node_modules/ssh2/node_modules/ssh2-streams/lib/ssh.js:555:13)
  at SSH2Stream.Transform._read [as __read] (_stream_transform.js:167:10)
  at SSH2Stream._read (/Users/arsenx/.atom/packages/nuclide-remote-projects/node_modules/nuclide-remote-connection/node_modules/ssh2/node_modules/ssh2-streams/lib/ssh.js:213:15)
  at SSH2Stream.Transform._write (_stream_transform.js:155:12)
  at doWrite (_stream_writable.js:295:12)
  at writeOrBuffer (_stream_writable.js:282:5)
  at SSH2Stream.Writable.write (_stream_writable.js:210:11)
  at Socket.ondata (_stream_readable.js:524:20)
  at emitOne (events.js:77:13)
  at Socket.emit (events.js:166:7)
  at readableAddChunk (_stream_readable.js:146:16)
  at Socket.Readable.push (_stream_readable.js:109:10)
  at TCP.onread (net.js:517:20)

[bolinfest]

I was doing something funny with Atom and didn't have apm installed when I ran the publish script, so all of the Node packages successfully deployed, but the Atom packages did not. I'm fixing that now.

[bolinfest]

[email protected] is now available! Please close this if everything works for you again.

[arsenx]

I see v0.0.30 is out, just installed it and still seem to be having some issues. I will confirm with you tomorrow morning. I'm gonna call it a night for today

[arsenx]

There is still an issue that persists with this module, after having tested it with the latest updates both locally and on the remote there still seems to be problems connecting to the server.
I am not depending on this module but would like to contribute on helping out in ironing out the issues!