Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

nuclide-remote / nuclide-file-tree colour marking #158

Open
arsenx opened this issue Aug 4, 2015 · 3 comments
Open

nuclide-remote / nuclide-file-tree colour marking #158

arsenx opened this issue Aug 4, 2015 · 3 comments

Comments

@arsenx
Copy link

arsenx commented Aug 4, 2015

System: OSX 10.0.4
Atom: 1.0.3
Nuclide: 0.0.26

When developing locally I have no issues with the colour, but when working with nuclide-remote the .gitignored files are not faint, new files are not green and modified files are not orange.

screen shot 2015-08-03 at 10 35 36 pm

I believe this issue may be related to a [nuclide-quick-open] issue where it is not able to index those files properly. I have also posted about that on #156

@bolinfest
Copy link
Contributor

This is a challenge to fix.

The reason why it works locally is because there is a GitRepository object that is bundled with Atom core rather than in its own npm package:

https://github.com/atom/atom/blob/master/src/git-repository.coffee

One of its core dependencies is the npm package git-utils, which contains native code:

https://www.npmjs.com/package/git-utils

So I'm not sure how difficult it would be to extract GitRepository into its own npm package.

If it exists as its own npm package, then we can make it a dependency of nuclide-server and run it there, just like we do with our Mercurial dependencies.

@bolinfest
Copy link
Contributor

I don't know that we have the bandwidth to fix atom/atom#8207 ourselves right now, and it is directly on the critical path for a real fix here. If you can get that fixed, then I'd be happy to wire it up to nuclide-server.

@arsenx
Copy link
Author

arsenx commented Aug 4, 2015

Oh I see that, yes it would be a great compliment to nuclide!
I hope they will take care of that sometime soon.
So I guess this isn't an issue just an enhancement. But more on an enhancement that has to be made on atom's side.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants