Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to bounded serde de/serialization #57

Open
daxpedda opened this issue Jan 24, 2022 · 3 comments
Open

Revert to bounded serde de/serialization #57

daxpedda opened this issue Jan 24, 2022 · 3 comments

Comments

@daxpedda
Copy link
Contributor

In #56 we will re-introduce some customized serde de/serialization again. This is because currently the VOPRF spec still actually produces zero scalars and identity points and we can't actually use the appropriate types to represent the fact that de/serialization should fail with zero scalars and identity points.

When this is resolved in the VOPRF spec, cfrg/draft-irtf-cfrg-voprf#307, we can use the appropriate types. For elliptic-curve that is PublicKey and SecretKey or NonIdentityPoint (something I was thinking of introducing) and NonZeroScalar, for curve25519-dalek we will have to introduce our own types.

@kevinlewi
Copy link
Contributor

@daxpedda just checking in, is this issue still relevant?

@daxpedda
Copy link
Contributor Author

daxpedda commented Jul 9, 2022

Theoretically, it's really code quality improvement only, maybe it's a bit overkill to have a whole issue for something like this, so feel free to close.
But yeah, eventually we should get back to it.

@daxpedda
Copy link
Contributor Author

Cc RustCrypto/traits#1170.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants