Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Using @dual-bundle/import-meta-resolve replace esm-resolve #824

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

nonzzz
Copy link
Contributor

@nonzzz nonzzz commented Dec 23, 2024

What changed / motivation ?

In the past we used esm-resolve to resolve es-based projects. But we need write two sets of code for cjs and esm. In cjs we using require.resolve and in other we using esm-resolve to create a resolve to do this. And in community @dual-bundle/import-meta-resolve allows us to avoid writing 2 sets of code.

Linked PR/Issues

Fixes # (issue)

Additional Context

Screenshots, Tests, Anything Else

Pre-flight checklist

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 23, 2024
@nmn nmn merged commit edc9b2a into facebook:main Dec 27, 2024
7 of 8 checks passed
@nonzzz nonzzz deleted the better-resolver branch December 27, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants