fix: avoid traversing on Program:enter
#786
Conversation
facebook-github-bot
added
the
CLA Signed
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
|
FWIW the RSD preset doesn't generate any StyleX code |
|
Is this something you can unit test to validate? |
I should explain better, but RSD will transform Is this something you can unit test to validate? Yes, I don't want to add a new dependency just for a test, so I'll try coming up with a minimal Babel plugin just for the test. (I tested this independently on top of tailwind-to-stylex.) |
nmn
force-pushed
the
fix/late-compilation
branch
from
49f3500 to
e4fa214
Compare
* fix: avoid traversing on Program:enter * chore: add a test for pre-plugins
* fix: avoid traversing on Program:enter * chore: add a test for pre-plugins
Better compatibility with pre-transformation
StyleX is sometimes used alongside other code transformation that can generate StyleX code. Examples include the React-Strict-DOM Babel plugin and
tailwind-to-stylex.The StyleX compiler has to do multiple passes of the entire tree to compile and then optimize the code. Previously, some of the transformations happened using a
path.traverseinProgram:enter. Because of how Babel runs multiple plugins, this meant that StyleX would often transform before previous transforms were completed. This could result incomplete compilation.This change moves some code around to move things to the normal tree traversal or
Program:exit. This will ensure that StyleX can consume any code generated by previous transforms.Note
There is no functional change to the output of the Babel plugin.