Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sapling cli build issues with python 3.13 #980

Open
yiding opened this issue Nov 8, 2024 · 0 comments
Open

sapling cli build issues with python 3.13 #980

yiding opened this issue Nov 8, 2024 · 0 comments

Comments

@yiding
Copy link
Contributor

yiding commented Nov 8, 2024

PyObject_AsCharBuffer has been deprecated in python 3 and removed as of python 3.13 in favor of PyObject_GetBuffer + PyBuffer_Release.

Currently mpatch.c is the only file that uses this old API.

if (PyObject_AsCharBuffer(tmp, &buffer, (Py_ssize_t*)&blen))


pipes, uu modules has been removed in 3.13, which is referenced in

https://github.com/facebook/sapling/blob/main/eden/scm/lib/python-modules/codegen/src/pycompile.py#L232

@yiding yiding changed the title sapling/cext/mpatch.c compilation errors w/ python 3.13 due to removal of PyObject_AsCharBuffer sapling cli build issues with python 3.13 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant