Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove automatic camel-casing of CSS custom property names #50

Open
necolas opened this issue Mar 10, 2024 · 0 comments · May be fixed by #73
Open

Remove automatic camel-casing of CSS custom property names #50

necolas opened this issue Mar 10, 2024 · 0 comments · May be fixed by #73
Labels
bug Something isn't working

Comments

@necolas
Copy link
Contributor

necolas commented Mar 10, 2024 •
edited
Loading

Describe the issue

The original StyleX shim added camel-casing of CSS custom property names to ease internal adoption of native theme definitions that map to web theme definitions. However, custom properties are case sensitive, and we have now implemented the StyleX theming APIs. So we should remove this inconsistency and allow variable names to be case sensitive.

Expected behavior

Custom property names are case sensitive and do not get automatically camel cased.

Steps to reproduce

N/A

Test case

No response

Additional comments

No response
@necolas necolas added the bug Something isn't working label Mar 10, 2024
@necolas necolas changed the title Remove automatic camelcasing of CSS custom property names Remove automatic camel-casing of CSS custom property names Mar 10, 2024
necolas added a commit that referenced this issue Apr 3, 2024
@necolas
Remove automatic camel-casing of CSS custom properties
2f33fd9 
Fix #50
@necolas necolas linked a pull request Apr 3, 2024 that will close this issue
Open
necolas added a commit that referenced this issue Apr 18, 2024
@necolas
Remove automatic camel-casing of CSS custom properties
60710ee 
Fix #50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove automatic camel-casing of CSS custom properties facebook/react-strict-dom
1 participant
@necolas