Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-strict-dom/babel export missing #240

Closed
HorusGoul opened this issue Nov 19, 2024 · 1 comment
Closed

react-strict-dom/babel export missing #240

HorusGoul opened this issue Nov 19, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@HorusGoul
Copy link

Describe the issue

A breaking change was introduced in 3431c9f (0.0.29), which is affecting the vite-plugin-stylex package, see this issue: HorusGoul/vite-plugin-stylex#93

We use the react-strict-dom/babel export when folks configure the import source like this:

    styleX({
      importSources: [
        {
          from: "react-strict-dom",
          as: "css",
        },
      ],
    }),

We do it here:

https://github.com/HorusGoul/vite-plugin-stylex/blob/85833306d294526e767def8a6f596c8fa4d87b6f/packages/vite-plugin-stylex/src/main.mts#L338

Expected behavior

Importing react-strict-dom/babel should return the babel plugin for RSD.

Steps to reproduce

  1. Install the latest react-strict-dom version
  2. require('react-strict-dom/babel')
  3. Won't work

Test case

No response

Additional comments

I understand the preset facilitates usage, but some folks might want additional configuration options for the underlying StyleX plugin included in the preset.

So, what's the plan? I can contribute the /babel export back if needed!

Thanks!

@HorusGoul HorusGoul added the bug Something isn't working label Nov 19, 2024
@necolas
Copy link
Contributor

necolas commented Nov 19, 2024

You should probably remove the RSD dependency from your project. RSD is prescriptive about how StyleX is used

@necolas necolas closed this as completed Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants