From d139b040b28a2a44bd57dde60b06205a1fda20c8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A1t=C3=A9=20Szab=C3=B3?= Date: Tue, 1 Oct 2024 12:32:43 +0200 Subject: [PATCH] Disable client identity propagation in the OSS build --- mcrouter/ServerOnRequest.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/mcrouter/ServerOnRequest.h b/mcrouter/ServerOnRequest.h index 2059c7bdc..dbc956806 100644 --- a/mcrouter/ServerOnRequest.h +++ b/mcrouter/ServerOnRequest.h @@ -11,7 +11,10 @@ #include #include +#ifndef MCROUTER_OSS_BUILD #include "core_infra_security/thrift_authentication_module/detail/ClientIdentifierHelper.h" +#endif + #include "mcrouter/CarbonRouterClient.h" #include "mcrouter/RequestAclChecker.h" #include "mcrouter/config.h" @@ -165,7 +168,8 @@ class ServerOnRequest { auto& reqRef = rctx->req; auto& ctxRef = rctx->ctx; - // Set hashed TLS client identities on request to propogate from proxy -> +#ifndef MCROUTER_OSS_BUILD + // Set hashed TLS client identities on request to propagate from proxy -> // memcache server only IF enableKeyClientBinding_ is enabled. if (FOLLY_UNLIKELY(enableKeyClientBinding_) && ctxRef.getThriftRequestContext()) { @@ -179,6 +183,8 @@ class ServerOnRequest { std::get(mayBeHashedIdentities.value())); } } +#endif + // if we are reusing the request buffer, adjust the start offset and set // it to the request. if (reusableRequestBuffer) {