Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded certificate verification will cause ssl errors for companies using SSL inspection #685

Open
sslMitmFunsies opened this issue Oct 22, 2024 · 0 comments

Comments

@sslMitmFunsies
Copy link

Currently at least 2 different locations specify that that certificate bundle in fb_ca_chain_bundle is used for SSL verification. This will cause ssl verification errors for developers whose companies use SSL inspection solutions. Recommend to either remove the code setting this entirely, or add an option to allow passing in extra certificates and documentation to back this. The former would be preferred. Currently developers would need to modify the library to add their company certificates.

The two locations:

And there is an additional reference set here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant