Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add missing types for nested Objects (such as Ads/insights/filtering) #38

Open
4 tasks done
bsless opened this issue Mar 23, 2022 · 0 comments
Open
4 tasks done
Labels
enhancement New feature or request

Comments

@bsless
Copy link

bsless commented Mar 23, 2022

Checklist

  • I've updated to the latest released version
  • I've searched for existing feature requests on GitHub issues
  • I've read the Code of Conduct
  • I've given my issue the title: Feature Request: [name of my feature request]

Goals

Be able to fully validate and describe the API, align to official references documentation

Expected Results

I expect a field like filtering to contain list<FilterObject> or list<AdRuleFilter> and not list<Object>

Code Samples & Details

FilterObject:

{
    "apis": [],
    "fields": [
        {
            "name": "field",
            "type": "string"
        },
        {
            "name": "operator",
            "type": "Filters_operator"
        },
        {
            "name": "value",
            "type": "Object"
        }
    ]
}

Ads/insights/filtering:

                {
                    "name": "filtering",
                    "required": false,
                    "type": "list<FilterObject>"
                },

Thanks

@bsless bsless added the enhancement New feature or request label Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant