-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
intersphinx mapping #1227
Comments
Hi @madeline-scyphers, thank you for reaching out. We will review this and get back to you. There may be some delay this week and next. Some questions:
|
Thanks!
|
Add docutils func that adds a reference to the relative __init__.py of all files __doc__ in each submodule change sphinx configuration to be nitpicky which revealed a bunch of broken sphinx links which were then fixed (except ax and botorch links which can't be fixed right now because they don't build sphinx in a normal way. see facebook/Ax#1227 and see pytorch/botorch#1464 for more info on when ax and botroch can be linked). Add more docstrings
Not an expert on this, but we move some of the sphinx build files to the static site dir here: https://github.com/facebook/Ax/blob/main/scripts/make_docs.sh#L97-L101 Presumably we could do the same for the |
Yeah, that might work. I didn't read through all of the workflow to see what happened to the static files later, and I noticed that on the with the command python -m sphinx.ext.intersphinx path/to/objects.inv you can pass it a local path instead of a url, so you might be able to test it with you post build script and making sure the objects.inv survives. But that only tests part of it, since I am not sure what all you all do to the sphinx static that could break things. But hopefully that should work. |
@madeline-scyphers Unfortunately we didn't have a chance to get to this. I added it to our wishlist tracking issue #566. Closing this one as we have tracking there. In the mean time if you prefer you can also send a PR instead. Thank you. |
I am working on a project that uses sphinx to build the docs. We use intersphinx to cross link to other projects and we would like to link to Ax for type hints and other resources. Because in Ax's docs scripts, after you build your docs with sphinx, you copy the html files for docusaurus and then the build doesn't have access to the generated
objects.inv
the gives the inventory of objects for intersphinx linking. Without it, you can't do the intersphinx mapping.I am not sure if it would be possible, but maybe if you also copy the
objects.inv
over as well. It usually goes in the same folder as yourindex.html
file, which is usually in the created_build
directory in sphinx, but that directory isn't there, so if you all did do this, maybe whereindex.html
is, so in theapi
folder in thegh_pages
branch.See related Botorch issue pytorch/botorch#1464
The text was updated successfully, but these errors were encountered: