Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional props #8

Open
oliverjam opened this issue Sep 28, 2018 · 0 comments
Open

Conditional props #8

oliverjam opened this issue Sep 28, 2018 · 0 comments

Comments

@oliverjam
Copy link

In your Egg component you're rendering two complete copies of the Screen in two branches of an if statement, even though there's only actually a single prop different (as far as I can tell just level is missing). You can conditionally set a prop with a ternary, e.g. level={this.state.name ? this.state.level : null}.

This probably isn't relevant if you made the changes suggested in #7 though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant