Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Workflow #55

Open
jema28 opened this issue Sep 16, 2018 · 1 comment
Open

GitHub Workflow #55

jema28 opened this issue Sep 16, 2018 · 1 comment
Labels

Comments

@jema28
Copy link

jema28 commented Sep 16, 2018

Travis: I noticed your most recent PRs have failing travis tests. I would fix this as your master branch should always have working code. Is travis something I can help with?

Issues: Good use of labels! 💯This could be improved for a client project though to include timeboxing e.g. T1d or T4h, and awaiting-review for your QA. It makes it much easier to see what you're expecting.

PRs

  1. It isn't automatically clear what some of the PRs are referring to e.g. "making pages". It's good practice to write a descriptive title short summary in the description (for you to look back on and for the QA to read).
  2. I would also include a link to the relevant issue that goes into more detail.
@developess
Copy link
Collaborator

The tests are working now! Rejoice!

I deffo agree on PRs, they could be a lot better! We've also not been good linking to issues as there are so many issues and a lot of them have been duplicates / cover loads of things 😱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants