You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Travis: I noticed your most recent PRs have failing travis tests. I would fix this as your master branch should always have working code. Is travis something I can help with?
Issues: Good use of labels! 💯This could be improved for a client project though to include timeboxing e.g. T1d or T4h, and awaiting-review for your QA. It makes it much easier to see what you're expecting.
PRs
It isn't automatically clear what some of the PRs are referring to e.g. "making pages". It's good practice to write a descriptive title short summary in the description (for you to look back on and for the QA to read).
I would also include a link to the relevant issue that goes into more detail.
The text was updated successfully, but these errors were encountered:
I deffo agree on PRs, they could be a lot better! We've also not been good linking to issues as there are so many issues and a lot of them have been duplicates / cover loads of things 😱
Travis: I noticed your most recent PRs have failing travis tests. I would fix this as your master branch should always have working code. Is travis something I can help with?
Issues: Good use of labels! 💯This could be improved for a client project though to include timeboxing e.g. T1d or T4h, and awaiting-review for your QA. It makes it much easier to see what you're expecting.
PRs
The text was updated successfully, but these errors were encountered: