Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResultsContainer #157

Open
tbtommyb opened this issue Oct 18, 2018 · 0 comments
Open

ResultsContainer #157

tbtommyb opened this issue Oct 18, 2018 · 0 comments
Assignees

Comments

@tbtommyb
Copy link

Just dumping a few things I noticed in this component:

Duplicating the array of elements here isn't required because both filter and map return new arrays so you aren't modifying the original props anyway.

Using an index as a key is generally an antipattern though I think you're ok here because you aren't changing the list once rendered.

You seem to have a lot of duplicated IDs on tags - is that intentional? IDs should be unique. One #revision-list is the actual list of missed items but the other one seems to be the score so I'm not sure why it's a list.

@Brymon Brymon self-assigned this Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants