You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just dumping a few things I noticed in this component:
Duplicating the array of elements here isn't required because both filter and map return new arrays so you aren't modifying the original props anyway.
Using an index as a key is generally an antipattern though I think you're ok here because you aren't changing the list once rendered.
You seem to have a lot of duplicated IDs on tags - is that intentional? IDs should be unique. One #revision-list is the actual list of missed items but the other one seems to be the score so I'm not sure why it's a list.
The text was updated successfully, but these errors were encountered:
Just dumping a few things I noticed in this component:
Duplicating the array of elements here isn't required because both
filter
andmap
return new arrays so you aren't modifying the original props anyway.Using an index as a key is generally an antipattern though I think you're ok here because you aren't changing the list once rendered.
You seem to have a lot of duplicated IDs on tags - is that intentional? IDs should be unique. One
#revision-list
is the actual list of missed items but the other one seems to be the score so I'm not sure why it's a list.The text was updated successfully, but these errors were encountered: