Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys in repo #147

Open
tbtommyb opened this issue Oct 18, 2018 · 2 comments
Open

Keys in repo #147

tbtommyb opened this issue Oct 18, 2018 · 2 comments
Assignees

Comments

@tbtommyb
Copy link

You have a key hardcoded here. I don't know if it should be secret but even so it should be in the env file.

@sima-qian
Copy link
Contributor

This is an interesting point. I don't think it's a key per se, rather it's an identifier for our database within airtable. In the airtable docs it's written in this way. You're right that it's worth moving it to a .env file for production.

@tbtommyb
Copy link
Author

Ah in that case it doesn't matter about it being in the repo but yeah you'd still want to be able to set different values to choose between dev/production tables.

@sima-qian sima-qian self-assigned this Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants