New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET performs a DB create #143

Open

tbtommyb opened this issue Oct 18, 2018 · 0 comments

Assignees

Labels

quick-fix server

tbtommyb commented Oct 18, 2018

Here you're creating a DB record in a GET request.

Generally requests that modify the server's state should use POST or PATCH and GET requests should be idempotent.

You do this correctly in the other create handlers so I guess this was just an oversight!

sima-qian added server quick-fix labels

sima-qian self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment