From b25b8a62fb81761b7aac382d029219a136d2b6cc Mon Sep 17 00:00:00 2001 From: joshuawilson Date: Wed, 14 Nov 2018 09:43:55 -0500 Subject: [PATCH] fix(build): remove gulp-ngc since it is not supported and replace with ngc call in gulp --- gulpfile.js | 23 +++++++++++++++++++---- package.json | 1 - 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/gulpfile.js b/gulpfile.js index 617616d..5698c5d 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -5,7 +5,7 @@ const gulp = require('gulp'), cssmin = require('gulp-cssmin'), del = require('del'), exec = require('child_process').exec, - gulpngc = require('gulp-ngc'), + // gulpngc = require('gulp-ngc'), fs = require("fs"), htmlMinifier = require('html-minifier'), lessCompiler = require('gulp-less'), @@ -13,7 +13,7 @@ const gulp = require('gulp'), path = require('path'), postcss = require('postcss'), replace = require('gulp-replace'), - rename = require('gulp-rename'); + rename = require('gulp-rename'), sourcemaps = require('gulp-sourcemaps'), stylelint = require('gulp-stylelint'), stylus = require('stylus'); @@ -185,7 +185,7 @@ function inlineTemplate() { } // Build the components -function transpile() { +//function transpile() { /** * Stick with gulp-ngc v0.2.1 due to "function calls are not supported in decorators" issue * @@ -195,9 +195,24 @@ function transpile() { * gulp-ngc v0.3.0 uses different args * See: https://github.com/jolly-roger/gulp-ngc/issues/9 */ - return gulpngc('tsconfig.json'); +// return gulpngc('tsconfig.json'); +//} +/** + * Since the gulpngc is no longer being supported we need to us ngc + * + * @returns {ChildProcess} + */ +function transpile() { + return exec('node_modules/.bin/ngc -p tsconfig.json', function (err, stdout, stderr) { + console.log(stdout); + console.log(stderr); + if (err !== null) { + process.exit(1); + } + }); } + // Build with AOT enabled function transpileAot() { // https://stackoverflow.com/questions/36897877/gulp-error-the-following-tasks-did-not-complete-did-you-forget-to-signal-async diff --git a/package.json b/package.json index f68189b..8ea7a4c 100644 --- a/package.json +++ b/package.json @@ -126,7 +126,6 @@ "gulp-changed": "3.2.0", "gulp-cssmin": "0.2.0", "gulp-less": "4.0.1", - "gulp-ngc": "0.2.1", "gulp-rename": "1.4.0", "gulp-replace": "1.0.0", "gulp-sourcemaps": "2.6.4",