Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature Request) Requesting a specific NVME disk size. #58

Open
842Mono opened this issue Jun 17, 2021 · 2 comments
Open

(Feature Request) Requesting a specific NVME disk size. #58

842Mono opened this issue Jun 17, 2021 · 2 comments
Labels
api enhancement New feature or request

Comments

@842Mono
Copy link
Contributor

842Mono commented Jun 17, 2021

We can request to reserve an NVME drive using this:

n1.add_component(ctype=ComponentType.NVME, model='P4510', name='nvme1')

But I'm not aware of a way to request a specific amount of NVME storage space. I imagine something like this (size is in GB for example):

n1.add_component(ctype=ComponentType.NVME, model='P4510', name='nvme1', size=100)
@842Mono 842Mono added the enhancement New feature or request label Jun 17, 2021
@paul-ruth
Copy link
Collaborator

The NVMe drives are "components" so you can only get full pci device.

However, I did notice that the Intel NVMe model "P4510" is actually a series (not a model) and can come in many sizes. So, there could be "P4510" of different sizes which would need to be different models wrt FABRIC.

Maybe the ones we have should be "P4510_4T" or something like that. Then we can identify the different models when we start using bigger ones b/c the standard sizes increase over time or they all get cheaper.

@paul-ruth paul-ruth added the api label Jun 17, 2021
@842Mono
Copy link
Contributor Author

842Mono commented Jul 3, 2021

Might be useful to add the size of the NVMe to its name. Example: P4510_4T_1TB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants