Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type checking #372

Open
sajith opened this issue Sep 17, 2024 · 0 comments
Open

Type checking #372

sajith opened this issue Sep 17, 2024 · 0 comments
Assignees

Comments

@sajith
Copy link
Member

sajith commented Sep 17, 2024

Running mypy --python-version 3.9 fabrictestbed_extensions/fablib/ reports hundreds of errors: "Found 488 errors in 12 files (checked 15 source files)", according to mypy 1.11.2, ran against commit 700964e.

Improving this situation should address issues like #295. We will need address the errors my reports, and run mypy on CI to prevent regressions.

Two things to note while adding static type checking:

@sajith sajith self-assigned this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant