Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are two Node.delete() methods #321

Closed
sajith opened this issue May 6, 2024 · 0 comments · Fixed by #323
Closed

There are two Node.delete() methods #321

sajith opened this issue May 6, 2024 · 0 comments · Fixed by #323
Labels
bug Something isn't working

Comments

@sajith
Copy link
Member

sajith commented May 6, 2024

While working on #318, I realized that there are two Node.delete() methods, and they are almost identical:

def delete(self):
self.get_slice().get_fim_topology().remove_node(name=self.get_name())

def delete(self):
for component in self.get_components():
component.delete()
self.get_slice().get_fim_topology().remove_node(name=self.get_name())

One of them should go. But which one has been getting called all this time?

@sajith sajith added the bug Something isn't working label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant