Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slice Builder Tests #175

Closed
7 of 11 tasks
yaxue1123 opened this issue May 16, 2022 · 3 comments · Fixed by #176
Closed
7 of 11 tasks

Slice Builder Tests #175

yaxue1123 opened this issue May 16, 2022 · 3 comments · Fixed by #176
Assignees
Labels
1.2 Release 1.2 item test

Comments

@yaxue1123
Copy link
Contributor

yaxue1123 commented May 16, 2022

@paul-ruth @ibaldin Please test portal slice builder via Experiments -> My Slices -> “Create Slice” and document any functional bug or usability concern in the comments here.

Feedback from Paul:

  • VM could be empty, doesn't have to include at least one component; TODO in 1.3
  • Add "Delete" button on the slice viewer;
  • Add a "Delete All Slices" button on the My Slices section; - TODO in 1.3
  • Update component wording to be consistent with FABLib. - TODO in 1.3

Delete A Slice:

  • Add Delete button in Slice Viewer for slices in state "StableOK" and "StableError";
  • Add confirmation modal after user clicks the delete button;
  • Change filter on My Slices from "Include Dead Slices" to "Include Dead/ Closing Slices";

@yaxue1123 will categorize the issues, update the slice builder for release 1.2, and plan for any significant improvement request for release 1.3.

@yaxue1123 need also write slice builder documentation:

  • User Guide, posted to Knowledge Base -> Topic: Technical User Guide?
  • Slice Builder API Call Flow Diagram;
  • Slice Builder Component Tree Diagram;
  • Wrap up requests for Orchestrator/ FIM? regarding the slice model (e.g. specify source -> target direction for links, adding layout properties for nodes, etc.) TODO in 1.3
@yaxue1123
Copy link
Contributor Author

yaxue1123 commented May 17, 2022

Slice Builder Diagrams - API Flowchart - v1

@yaxue1123
Copy link
Contributor Author

Slice Builder Diagrams - Component Tree - v1

@paul-ruth
Copy link

For the "delete" and "delete all" buttons it should pop a box that requires the user to confirm the delete.

yaxue1123 added a commit that referenced this issue May 24, 2022
yaxue1123 added a commit that referenced this issue May 25, 2022
@yaxue1123 yaxue1123 linked a pull request May 25, 2022 that will close this issue
@ibaldin ibaldin added 1.3 Release 1.3 item 1.2 Release 1.2 item and removed 1.3 Release 1.3 item labels May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.2 Release 1.2 item test
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants