Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with Sense AWS. Fabric slice expiring fails to to delete AL2S connection. #48

Open
abessiari opened this issue Jun 23, 2023 · 2 comments
Assignees
Labels

Comments

@abessiari
Copy link
Contributor

abessiari commented Jun 23, 2023

When the FABRIC slice expires, it will fail to delete the OESS connection which depends on the deletion of the AWS direct connect VPC attachment. This OESS connection might be incorrectly reused by subsequent workflows using the same workflow name.

NOTE: Calling fabfed workflow destroy will only delete the sense portion if the FABRIC slice has expired.

@xi-yang
Copy link
Contributor

xi-yang commented Jun 24, 2023

Potential features design:

  1. immediately renew the FABRIC slice to last longer. (-show should give a warning about the expiry and potential issues, like OESS connection not going away ...)
  2. Develop a -renew operation for the workflow session.
  3. Register with a provider (or 3rd party) notification service (email / text / slack etc.) to remind users to renew or destroy the workflow before the expiry.

@xi-yang
Copy link
Contributor

xi-yang commented Sep 13, 2023

@abessiari Let's use fablib slice.renew() call to extend a FABRIC slice life time to 14 days. This should buy us time to clean up most of workflows.

https://github.com/fabric-testbed/fabrictestbed-extensions/blob/e716c26b0aa8d04a8103922bb892500329f22c2d/fabrictestbed_extensions/fablib/slice.py#L1409

14 days is the default max number of days for renewal. With Slice.NoLimitLifetime permission tag on a project, we can do up to 26 weeks.

@xi-yang xi-yang changed the title Integration with Sense AWS. Fabric slice expiring fails to to delete OESS connection. Integration with Sense AWS. Fabric slice expiring fails to to delete AL2S connection. Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants