Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postprocessing data read enhancements #376

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

timcowlishaw
Copy link
Contributor

Fixes #374, gives each device a first_reading_at property, populated on ingest, and allows passing of a limit parameter to the readings endpoint (applied before rollups)

🚨 REQUIRES migrations and the devices:set_first_reading_at task to be run on deploy 🚨

Future work:
- improve test coverage (on presenters themselves)
- Look into API versioning, use this representation in HTTP API too in a
  new version
- Delete old formatting code once released.
- Sort out the mess of different reading representations we use in
  different places and radically simplify that part of everything
Move shared code into top level application controller, add Devices#show
and Devices#index using new presentations
@timcowlishaw timcowlishaw force-pushed the postprocessing-data-read-enhancements branch from f31c421 to 402cf96 Compare November 21, 2024 10:03
@timcowlishaw timcowlishaw force-pushed the postprocessing-data-read-enhancements branch from 402cf96 to 6c4f267 Compare November 27, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add parameters to readings query
1 participant