-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postprocessing data read enhancements #376
Open
timcowlishaw
wants to merge
17
commits into
master
Choose a base branch
from
postprocessing-data-read-enhancements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Future work: - improve test coverage (on presenters themselves) - Look into API versioning, use this representation in HTTP API too in a new version - Delete old formatting code once released. - Sort out the mess of different reading representations we use in different places and radically simplify that part of everything
Move shared code into top level application controller, add Devices#show and Devices#index using new presentations
…ed to sidekiq are strings
timcowlishaw
force-pushed
the
postprocessing-data-read-enhancements
branch
from
November 21, 2024 10:03
f31c421
to
402cf96
Compare
timcowlishaw
force-pushed
the
postprocessing-data-read-enhancements
branch
from
November 27, 2024 06:57
402cf96
to
6c4f267
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #374, gives each device a
first_reading_at
property, populated on ingest, and allows passing of alimit
parameter to the readings endpoint (applied before rollups)🚨 REQUIRES migrations and the
devices:set_first_reading_at
task to be run on deploy 🚨