Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the hardcoded value on country "Taiwan" #77

Open
andythsu opened this issue Dec 6, 2018 · 2 comments
Open

Change the hardcoded value on country "Taiwan" #77

andythsu opened this issue Dec 6, 2018 · 2 comments

Comments

@andythsu
Copy link

andythsu commented Dec 6, 2018

Hi,
I'm not trying to be nitpicky here, but when I looked at the code at line 1166 on paper-chip/demo/index.html, it marks

{
     "label": "Taiwan, Province of China",
     "value": "TW"
},

I don't think that reflects the reality of where Taiwan should belong to.

If you look at https://www.state.gov/misc/list/index.htm#t , it actually says Taiwan as a country, not province of China.

If you could change that label, that'd be much appreciated.

Thank you!

@chrisxujh
Copy link

"List of Country and Other Area Pages". TW might not be a country but "Other Area"

@chrisxujh
Copy link

Please refer to the constitution from TW: https://english.president.gov.tw/page/93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants