Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read EXR files from memory #1187

Open
Meakk opened this issue Jan 19, 2024 · 16 comments
Open

Read EXR files from memory #1187

Meakk opened this issue Jan 19, 2024 · 16 comments
Assignees
Labels
good first issue Good for newcomers help wanted Please help with this issue! type:enhancement New feature or request
Milestone

Comments

@Meakk
Copy link
Contributor

Meakk commented Jan 19, 2024

Is your feature request related to a problem? Please describe.
Some file formats like USD can read textures as EXR file format. For reading them properly, we need to read the file from memory.

Describe the solution you'd like
Handle SetMemoryBuffer in the vtkF3DEXRReader

@Meakk Meakk added type:enhancement New feature or request good first issue Good for newcomers priority:P0 labels Jan 21, 2024
@mwestphal mwestphal added this to F3D Feb 3, 2024
@mwestphal mwestphal added this to the 2.4.0 milestone Feb 4, 2024
@mwestphal mwestphal added the help wanted Please help with this issue! label Feb 4, 2024
@mwestphal mwestphal moved this to To do in F3D Feb 4, 2024
@yigitako
Copy link

I can work on this issue.

@mwestphal
Copy link
Contributor

Nice!

@mwestphal mwestphal moved this from To do to In progress in F3D Feb 11, 2024
@mwestphal
Copy link
Contributor

@yigitako any news on this ?

@mwestphal mwestphal modified the milestones: 2.4.0, 2.5.0 Apr 4, 2024
@mwestphal
Copy link
Contributor

Any news on this feature @yigitako ?

@mwestphal
Copy link
Contributor

with no feedback, I'm unassainging this @yigitako

@nabielkandiel
Copy link

@mwestphal I am starting to look into this

@mwestphal
Copy link
Contributor

hey @nabielkandiel , what is the status of this ?

@gapry
Copy link

gapry commented Oct 7, 2024

@Meakk @mwestphal I'd like to work on this issue. Could you please assign it to me?

@Meakk
Copy link
Contributor Author

Meakk commented Oct 7, 2024

@gapry it's almost done here: #1448
The previous contributor doesn't seem active anymore, so feel free to take a look and let us know if you want to take over and finalize it.

@gapry
Copy link

gapry commented Oct 7, 2024

@Meakk Thank you for the update. I’d be happy to take over and finalize the issue to ensure its successful completion. I will take some time to review PR #1448 thoroughly, and if I have any questions or need clarification, I’ll leave comments and discuss them with you directly in the PR.

@mwestphal
Copy link
Contributor

@gapry any news on this ?

@gapry
Copy link

gapry commented Nov 1, 2024

@mwestphal Sorry, I need more time, I anticipate having the first patch ready between the 22nd and 24th of this month.

@mwestphal
Copy link
Contributor

No worries!

@gapry
Copy link

gapry commented Nov 23, 2024

I attempted two approaches to contribute to the pull request #1448

First Approach

git clone [email protected]:nabielkandiel/f3d.git pr-1448
cd pr-1448
git checkout feature/1187-exr-from-memory
vim testing/data/DATA_LICENSES.md
git add testing/data/DATA_LICENSES.md
git commit -S -m "add the links for small.usdz dataset license"
git push origin feature/1187-exr-from-memory

However, I encountered a permissions error

ERROR: Permission to nabielkandiel/f3d.git denied to gapry.

Second Approach

git clone [email protected]:f3d-app/f3d.git 
cd f3d
git remote add nabielkandiel-pr-1448 https://github.com/nabielkandiel/f3d.git
git fetch nabielkandiel-pr-1448 feature/1187-exr-from-memory
git checkout -b pr-1448 nabielkandiel-pr-1448/feature/1187-exr-from-memory
vim testing/data/DATA_LICENSES.md
git add testing/data/DATA_LICENSES.md
git commit -S -m "add the links for small.usdz dataset license"
git push origin pr-1448

While this approach allowed me to create a new branch (pr-1448) on my fork, I cannot push changes directly to the original pull request #1448

Question

How can I contribute my changes to the original pull request? Thanks

Ref

@mwestphal
Copy link
Contributor

How can I contribute my changes to the original pull request? Thanks

The original branch is not in our (the maintainers) control, so the second approach is indeed correct. Once you have created a new PR with the code, I'll close the original PR and development will continue in your branch.

@gapry
Copy link

gapry commented Nov 26, 2024

@mwestphal I've created the new PR: #1733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Please help with this issue! type:enhancement New feature or request
Projects
Status: In progress
Development

No branches or pull requests

5 participants