-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-3265: Fixed translation of User content objects #63
Open
webhdx
wants to merge
4
commits into
1.3
Choose a base branch
from
IBX-3265_Translation_of_User_Content_Objects_is_not_possible
base: 1.3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
IBX-3265: Fixed translation of User content objects #63
webhdx
wants to merge
4
commits into
1.3
from
IBX-3265_Translation_of_User_Content_Objects_is_not_possible
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n translating User
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This was referenced Nov 29, 2022
ViniTou
approved these changes
Nov 30, 2022
ciastektk
approved these changes
Nov 30, 2022
konradoboza
approved these changes
Nov 30, 2022
Regression tests passed: ibexa/commerce#168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like translating User content objects was never working properly. Architecture of Content editing forms is very limiting thus the solution is not perfect. It required a few steps to fix the issue:
User
object with incorrect language was passed toUserUpdateMapper
which prevented displaying an editing formFieldValueValidator
was defined as data constraint which had to be changed to form constraint in order to provide more context to the validator. Intuitively you'd use validation groups here but it isn't possible with how we dynamically map fields. Right now the form will defineFieldValue
constraint withintent
option passed as payload. Then the validator itself can detect wether it should skip validation on nontranslatable fieldtypes.Content
object to checkmainLanguageCode
.