IBX-3265: Fixed translation of User Content Objects #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
approved these changes
Nov 30, 2022
konradoboza
approved these changes
Nov 30, 2022
| @@ -54,7 +55,12 @@ public function createContentDraft(FormActionEvent $event): void | |||
| return; | |||
| } | |||
|
|
|||
| $contentDraft = $this->contentService->createContentDraft($data->content->contentInfo); | |||
| if ($data->content->getVersionInfo()->status === VersionInfo::STATUS_DRAFT) { | |||
There was a problem hiding this comment.
$data->content can be a variable since it's used in all cases.
|
Kudos, SonarCloud Quality Gate passed!
|
ciastektk
approved these changes
Nov 30, 2022
|
Regression tests passed: ibexa/commerce#168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complementary PR to: ezsystems/ezplatform-content-forms#63
Main change here changes translation to use correct route
ezplatform.content.translatewhen using autosave option. To prevent creating new drafts, it'll acceptversionNoparameter now and use requested draft for editing.Checklist:
$ composer fix-cs)