Should we be saving files on user's behalf?

[JosiahParry]

I just came across the function try_save_all() and noticed it is used in rextendr::document().

This function saves all open files if possible. To me, this feels somewhat invasive and can lead to rextendr saving files that the user didn't intend to.

Should we remove this function and expect users to save their files on their own?

rextendr/R/try_save_all.R

Line 8 in 3ee8ae3

try_save_all <- function(quiet = FALSE) {

[CGMossa]

Agreed, we shouldn't be doing that in document.

[Ilia-Kosenkov]

This was someone's (don't remember whose) desire to integrate with RStudio IIRC.

[JosiahParry]

@Ilia-Kosenkov are you okay with removing this function? If so, I can make a PR to yank it

[Ilia-Kosenkov]

I am not a fan of this function for sure so go ahead :)