New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use_crate fails when no features specified #387

Closed

JosiahParry opened this issue Sep 17, 2024 · 1 comment

Contributor

JosiahParry commented Sep 17, 2024

          This change broke the function. Looks like we might be missing a test for this. I installed the new version

rextendr::use_crate("lazy-static")
Running cargo add lazy-static '--features ' '--optional false'
Error:
! ! System command 'cargo' failed

This is because "--features " is included in the vector that is passed to processx. --features

Originally posted by @JosiahParry in #361 (comment)

The text was updated successfully, but these errors were encountered:

kbvernon mentioned this issue

check for empty string in use_crate() #388

Merged

Member

CGMossa commented Nov 18, 2024

Fixes by #388 (thanks @kbvernon for both the PR, and for notifying me that this issue can now be closed)

CGMossa closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment