Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font/color mismatch in Light Mode #1696

Closed
cengizcmataraci opened this issue Nov 24, 2024 · 5 comments
Closed

Font/color mismatch in Light Mode #1696

cengizcmataraci opened this issue Nov 24, 2024 · 5 comments

Comments

@cengizcmataraci
Copy link
Contributor

Hello. I have noticed that there is a little mismatch in Light Mode. I think the selection of font and color is not compatible with eye comfort and visibility in the description area on main page.

Screenshot 2024-11-24 at 18 21 33

I suppose it should have a darker color, maybe more bold. It works in dark mode perfectly, but I think it's not good in light mode.

Is there any purpose for selecting this font and color? And do you think it should be changed? I don't know if it's important, but it seems to me that it's important both in terms of aesthetics and accessibility.

@bjohansebas
Copy link
Member

Hi @cengizcmataraci, the color is already planned to be changed (see #1628), I don't think the font will be changed for now, although I would actually like to (maybe Geist font). I don't know, it's very subjective. Maybe you could open a PR changing the font to see if we like it.

@cengizcmataraci
Copy link
Contributor Author

Sure, I know it's a minor change, but as I said before, it's better for eye comfort.

@cengizcmataraci
Copy link
Contributor Author

By the way, I didn't change the font, I changed the color a little bit but if you don't think it's good it's alright.

@bjohansebas
Copy link
Member

I like the change, there are many things to fix in terms of accessibility on this page, but little by little it's getting done.

@bjohansebas
Copy link
Member

fixed by #1697

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants