Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move image storage location of News & Notes- EXO-64344 (#169) #176

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

ahamdi
Copy link
Member

@ahamdi ahamdi commented Nov 6, 2023

This upgrade plugion will move the images folders of :

Notes : from SPACE_ROOT/Documents/notes/images to SPACE_ROOT/notes/images
News : from SPACE_ROOT/Documents/news/images to SPACE_ROOT/News/images

It could be reused for similar cases , we have just to give a new name to the plugin and define the source path and the target path with a list of folders to remove if needed

<value-param>
<name>plugin.upgrade.target.version</name>
<description>Target version of the plugin</description>
<value>6.5.0</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't target version be 6.4.4 @ahamdi ?

<parent>
<groupId>org.exoplatform.addons.upgrade</groupId>
<artifactId>upgrade</artifactId>
<version>6.5.x-maintenance-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't version be 6.4.4 @ahamdi ?

@ahamdi ahamdi requested a review from Jihed525 November 7, 2023 07:50
@ahamdi ahamdi self-assigned this Nov 7, 2023
@ahamdi ahamdi requested a review from akhanfir November 7, 2023 07:50
@ahamdi ahamdi enabled auto-merge (squash) November 7, 2023 07:51
This upgrade plugion will move the images folders of :

    Notes : from SPACE_ROOT/Documents/notes/images to SPACE_ROOT/notes/images
    News : from SPACE_ROOT/Documents/news/images to SPACE_ROOT/News/images
It could be reused for similar cases , we have just to give a new name to the plugin and define the source path and the target path with a list of folders to remove if needed
Copy link

sonarcloud bot commented Nov 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

63.2% 63.2% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ahamdi ahamdi merged commit cee45ef into stable/6.4.x Nov 7, 2023
3 of 4 checks passed
@ahamdi ahamdi deleted the Merge/6.4/EXO-64344 branch November 7, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants