You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This case study has: "r_pl = pm.Deterministic("r_pl", ror * r_star)" for calculating the planetary radius. According to the documentation for get_light_curve, r_pl is in units of solar radii, not the host star radius. However, this example gets ror from get_ror_from_approx_transit_depth, for which the documentation says ror is the radius ratio and is not explicit about units. I suggest clarifying in both the case study tutorial and in the documentation about the units.
The text was updated successfully, but these errors were encountered:
Hi @ernewton — I believe that the docs and the tutorial are both correct in this case. r_pl has units of Solar radii, and when we call get_light_curve, we use:
This case study has: "r_pl = pm.Deterministic("r_pl", ror * r_star)" for calculating the planetary radius. According to the documentation for get_light_curve, r_pl is in units of solar radii, not the host star radius. However, this example gets ror from get_ror_from_approx_transit_depth, for which the documentation says ror is the radius ratio and is not explicit about units. I suggest clarifying in both the case study tutorial and in the documentation about the units.
The text was updated successfully, but these errors were encountered: